13f030ddf8
Fix #14777 : authorized_key: Correctly target key type for add/remove
...
The logic in ConNetworkAuthorizedKey for the `authorized_key` command was inverted.
The check `if (StrEqualsIgnoreCase(type, name)) continue;` caused the action (add/remove) to be incorrectly executed on the first key type encountered that *did not* match the requested type, rather than the intended one. This resulted in keys specified for 'admin' being added to 'rcon', for example.
This commit inverts the condition to ensure the action is performed only when the requested type matches the iterated key name.
2025-12-08 04:56:27 +05:00
09858583be
Codefix: Make sure safeguards.h is the last included non-table header. ( #14687 )
2025-12-08 04:32:55 +05:00
62e9ac00b9
Fix f6c5da4cad: dump_info should not reverse non-ASCII label. ( #14697 )
...
Cargo/rail/road types labels are already in appropriate endian-ness.
2025-12-08 04:29:55 +05:00
4fec64525a
Merge branch 'openttd'
2025-09-01 23:28:07 +05:00
e6323e6760
Fix: File/directory titles not updated if language is changed. ( #14542 )
2025-08-28 17:42:00 +01:00
140f2b291a
Codechange: Use ProviderManager interface to register FontCache factories.
...
This removes use of #ifdefs to select the appropriate loader, and also replaces FontCache self-registration.
2025-08-07 19:38:00 +01:00
0dc40877fd
Codechange: Initialise/reset font cache with FontSizes bitset. ( #14448 )
...
Instead of choosing either "Normal/Small/Large" or "Monospace", use an EnumBitSet to allow any combination.
2025-07-18 18:23:28 +01:00
9238f508eb
Fix #14081 : Check if removed item is a savegame ( #14371 )
2025-06-18 10:05:18 +02:00
f388ddce1f
Merge branch 'openttd'
2025-06-09 19:30:22 +05:00
77d6f6c69f
Codechange: Make ContentType::State an enum class. ( #14279 )
2025-05-19 17:11:28 +01:00
b20b6da937
Codechange: The compiler ensures static variables are initialised only once, no need to track that manually.
2025-05-06 18:29:41 +02:00
0d5b3ebd7f
Codechange: Declare all IntervalTimers const, which can be const.
2025-05-06 18:29:41 +02:00
61cec33be2
Codechange: Add 'const' to static variables, which are only initialised once.
2025-05-06 18:29:41 +02:00
8571af9833
Codechange: Turn ZoomLevel into enum class.
2025-05-03 23:21:09 +02:00
48d09af039
Codechange: Simplify weird range check.
2025-05-03 23:21:09 +02:00
9ac9798d7f
Codechange: Remove usages of stoi and stol. ( #14196 )
2025-05-03 17:46:30 +02:00
1f39d469ff
Codechange: pass the characters to trim to StrTrimView
2025-05-03 15:57:53 +02:00
e2db8277b8
Codefix: implement StrTrimInPlace without assigning a borrowed view of itself
2025-05-03 15:57:53 +02:00
855377191e
Codechange: replace some more char*s with std::string_view
2025-04-30 23:49:06 +02:00
fda93b6f35
Codechange: Add format_append as short-hand to format_to + back_inserter.
2025-04-29 20:26:23 +02:00
3973199879
Change: ParseInteger now checks for trailing junk chars.
2025-04-29 20:14:56 +02:00
af25eecc15
Codechange: use const for std::string_view where appropriate
2025-04-29 10:15:18 +02:00
9107c3f6c6
Codechange: add std::string_view variant of FileHandle::Open
2025-04-28 21:31:12 +02:00
49ef3eee13
Codechange: replace char* with std::string_view
2025-04-27 20:08:02 +02:00
365eed533d
Codechange: use std::string_view for console commands
2025-04-26 14:15:10 +02:00
08ce16018b
Codechange: make start-ai console command parsing work with std::string_view
2025-04-25 19:04:22 +02:00
ccbf7f4a46
Codechange: validate the given seed
2025-04-25 19:04:22 +02:00
86039a5b69
Codechange: make SetDebugString use C++-style strings and function types
2025-04-25 19:04:22 +02:00
498a0f1c1b
Codechange: use C++ strings over C-strings
2025-04-25 19:04:22 +02:00
2087bca87d
Codechange: replace atoi with ParseInteger in console commands
2025-04-24 18:10:01 +02:00
ddc0d6ead3
Codechange: use string comparision for ConExec's second parameter
2025-04-24 18:10:01 +02:00
4149384ebc
Codechange: simplify and move GetArgumentInteger
2025-04-22 23:16:15 +02:00
917ef03e97
Codechange: use std::string_view in IConsole settings API
2025-04-22 19:52:37 +02:00
f82e172610
Codechange: Expand and remove DEF_CONSOLE_CMD and DEF_CONSOLE_HOOK macros.
2025-04-18 17:16:48 +02:00
26db4ccf09
Codechange: Turn bit-stuffed FiosType enum into a struct. ( #14019 )
2025-04-18 15:20:55 +02:00
20d83677eb
Codechange: Use unique_ptr to manage ContentInfo lifetime.
...
Removes manually managed new/delete.
2025-04-11 23:08:59 +01:00
7b31f26611
Codechange: Pass ContentInfo by reference.
...
Many functions take a ContentInfo pointer, but do not check for nullptr.
Pass by reference instead to assure it is present.
2025-04-11 23:08:59 +01:00
8275bbfb87
Codechange: Pass Viewport by reference.
...
This means we do not have to care what type of pointer is used.
2025-04-09 22:03:23 +01:00
9229956f04
Codechange: Replace strcasestr with StrContainsIgnoreCase.
2025-04-09 17:19:11 +02:00
04246c530f
Codechange: Use fmt::format instead of stringstream with iomanip flags. ( #13964 )
2025-04-08 20:57:50 +00:00
981b2a94db
Codechange: Store loaded GRFFiles in vector directly. ( #13940 )
...
Removes pointer management.
2025-04-06 20:16:57 +01:00
2ae84f3c9e
Codechange: CargoSpec::Iterate already tests cargo validity. ( #13941 )
2025-04-01 18:23:26 +01:00
2909a14374
Codechange: Include table/strings.h in files that use StringIDs.
...
Be consistent with how and where the file is incldued.
2025-03-21 12:53:40 +00:00
754311a779
Codechange: use std::move when appropriate
2025-03-13 13:00:24 +01:00
a955f0f3cc
Merge 1.5.0-beta1
2025-02-27 17:55:40 +05:00
fd4adc55e3
Codechange: replace INVALID_X with XID::Invalid() for PoolIDs
2025-02-16 20:23:00 +01:00
ab8177ea77
Codechange: strongly type CompanyID
2025-02-16 14:02:18 +01:00
6cf7a899e9
Codechange: Use EnumBitSet for PauseMode. ( #13553 )
2025-02-14 08:30:04 +00:00
20e57a02a2
Codechange: Use GetString() with argument parameters in simple cases. ( #13551 )
...
Avoids using global string parameters.
2025-02-14 00:10:56 +00:00
d61b376998
Codechange: Use EnumBitSet for CargoClasses. ( #13491 )
2025-02-08 08:46:38 +00:00
Muxy Du Goulp