0d5b3ebd7f
Codechange: Declare all IntervalTimers const, which can be const.
2025-05-06 18:29:41 +02:00
61cec33be2
Codechange: Add 'const' to static variables, which are only initialised once.
2025-05-06 18:29:41 +02:00
d571491405
Codechange: Replace std::bitset<CONTENT_TYPE_END> with ContentTypes. ( #14223 )
...
#14214 added `ContentTypes` as en `EnumBitSet`, but some std::bitset existed already; they are now `ContentTypes` too.
2025-05-06 17:20:01 +01:00
2355d67e11
Codechange: Use EnumBitSet instead of Vector to record received content types. ( #14214 )
2025-05-05 08:55:34 +01:00
ac76212b80
Fix: Closing the Game Options window closes all textfile windows.
...
Record the parent window that opens a textfile window so only child windows are closed instead of all.
2025-05-04 19:36:46 +01:00
5e3c7c4146
Codechange: char* -> char *
2025-05-04 10:43:56 +02:00
3f2b39e3f8
Codechange: replace char* where out-of-date
2025-05-04 10:43:56 +02:00
96fd291693
Codechange: introduce GetEnv that returns optional based on std::getenv
2025-05-03 15:58:14 +02:00
1f39d469ff
Codechange: pass the characters to trim to StrTrimView
2025-05-03 15:57:53 +02:00
7805c1c189
Codechange: use std::string_view for ini_key
2025-05-01 23:24:43 +02:00
9cf36dac39
Codechange: Use data() instead of c_str(), if no NUL termination is needed.
2025-04-30 19:33:56 +02:00
9e90d4ed79
Codefix: Do not assign nullptr to std::string_view.
2025-04-30 19:33:56 +02:00
36ce1f890a
Codechange: Remove c_str, if std::string_view is already accepted.
2025-04-30 19:33:56 +02:00
ef71ce0a9d
Codechange: return std::string_view for Textbuf::GetText()
2025-04-29 22:15:49 +02:00
afe3dfb3a4
Codechange: Use format instead of to_string.
2025-04-29 20:26:23 +02:00
fda93b6f35
Codechange: Add format_append as short-hand to format_to + back_inserter.
2025-04-29 20:26:23 +02:00
cdafc50c94
Codechange: Replace atoi and atoll with ParseInteger.
2025-04-29 20:14:56 +02:00
79b2202f2e
Codechange: Use StringConsumer for parsing more strings.
2025-04-29 20:14:56 +02:00
e7d758c82a
Codechange: Replace sscanf with StringConsumer.
2025-04-29 20:14:56 +02:00
af25eecc15
Codechange: use const for std::string_view where appropriate
2025-04-29 10:15:18 +02:00
9116f96e2e
Codechange: replace char * with std::string_view
2025-04-28 17:53:18 +02:00
c6ea0ce961
Codechange: use std::span for transferring data in network code
2025-04-28 17:53:18 +02:00
49ef3eee13
Codechange: replace char* with std::string_view
2025-04-27 20:08:02 +02:00
29ceaf0a84
Codechange: use std::string_view over const char *
2025-04-27 18:04:04 +02:00
b87ce9c845
Change: Draw info headers as shade of window colour instead of pixel colour. ( #14123 )
...
Use the normal or lightest colour gradient to pick a suitable colour, instead of an arbitrary pixel colour.
(Except for the NewGRF window's info panel, this happens to be the same colour.)
2025-04-26 22:38:24 +01:00
30f381acee
Codechange: use std::string_view for NetworkAddress
2025-04-26 16:30:16 +02:00
42f0aa24f6
Codechange: use std::string_view for connection/URI strings
2025-04-26 16:30:16 +02:00
a5812a45f8
Codechange: use std::string view for URI and std::move for data
2025-04-26 16:30:16 +02:00
87b5b0ffa3
Fix 2b80812922: Map size column in server list may be too wide. ( #14094 )
...
Incorrect change from SetDParamMaxValue to GetParamMaxValue.
2025-04-24 21:05:31 +01:00
7846f0f4ee
Fix a4dc7249ee: Changing language or interface scale could hang. ( #14087 )
...
A bit of hysteresis caused by OnResize calling ReInit calling OnResize calling ReInit calling OnResize calling ReInit ...
2025-04-24 00:29:54 +01:00
2a62eea005
Codefix: Comment style. ( #14064 )
2025-04-21 17:25:09 +02:00
0cf7048a67
Change: Don't select content when toggling its download status. ( #14059 )
...
This improves usability when toggling content sorted by status, as the list position no longer jumps to the now (de)selected item, making it easier to (de)select multiple items.
2025-04-21 13:20:52 +01:00
4e14f0ac3f
Codechange: pass network tokens as std::string_view or with move semantics where appropriate
2025-04-20 22:43:24 +02:00
c13956a58a
Codechange: use std::string_view for connection strings
2025-04-20 22:43:24 +02:00
31433882a4
Codechange: use std::string_view for passing NetworkError strings
2025-04-20 22:43:24 +02:00
cb113cfed0
Codefix: Add missing header includes.
2025-04-20 22:06:18 +02:00
26de3404a4
Codechange: use std::string_view for sending chat messages
2025-04-20 13:31:41 +02:00
bb259b8e77
Codechange: use std::string_view for sending a remote console command (result)
2025-04-20 13:31:41 +02:00
d99edf2bbc
Codechange: use std::string_view for kicking/banning
2025-04-20 13:31:41 +02:00
a0246bc8a7
Codechange: use std::string_view over std::string for NetworkTextMessage
2025-04-20 13:31:41 +02:00
a0e4dab771
Codechange: use std::string_view for NetworkAddress::IsInNetmask of std::string
2025-04-20 13:31:41 +02:00
26db4ccf09
Codechange: Turn bit-stuffed FiosType enum into a struct. ( #14019 )
2025-04-18 15:20:55 +02:00
5008568dfc
Codechange: Rename CenterBounds to CentreBounds and move to geometry header. ( #14002 )
2025-04-14 23:55:40 +01:00
1744156149
Change: Queue content ID information requests. ( #13990 )
...
Instead of requesting content one ID at a time, queue them up to be requested in one go.
* Avoids sending many small requests.
* Avoids sending requests for content which is likely to be arriving anyway.
2025-04-12 12:50:36 +01:00
3347919fb2
Codechange: Remove empty destructor and use member init for ClientNetworkContentSocketHandler.
2025-04-11 23:08:59 +01:00
20d83677eb
Codechange: Use unique_ptr to manage ContentInfo lifetime.
...
Removes manually managed new/delete.
2025-04-11 23:08:59 +01:00
7b31f26611
Codechange: Pass ContentInfo by reference.
...
Many functions take a ContentInfo pointer, but do not check for nullptr.
Pass by reference instead to assure it is present.
2025-04-11 23:08:59 +01:00
413087df9d
Codechange: Use small function to get check handler for content type. ( #13988 )
...
This reduces a long switch block with (multiple) breaks with the power of early return.
2025-04-10 20:45:43 +00:00
936d78fefc
Codefix: Avoid uppercase characters in variable names. ( #13985 )
2025-04-10 07:19:27 +01:00
fa284af263
Codechange: Replace remaining Utf8Encode usages with StringBuilder.
2025-04-08 23:10:58 +02:00
frosch