miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: Use parameterised GetString() for script-related windows. (#13671)

Browse Source
This commit is contained in:
Peter Nelson
2025-02-27 23:53:04 +00:00
committed by GitHub
parent e2c1b9f03e
commit ddb502d097
5 changed files with 82 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/script/script_config.cpp
View File

@@ -191,3 +191,35 @@ ScriptInstance::ScriptData *ScriptConfig::GetToLoadData()
return this->to_load_data.get();
}
static std::pair<StringParameter, StringParameter> GetValueParams(const ScriptConfigItem &config_item, int value)
{
if ((config_item.flags & SCRIPTCONFIG_BOOLEAN) != 0) return {value != 0 ? STR_CONFIG_SETTING_ON : STR_CONFIG_SETTING_OFF, {}};
auto it = config_item.labels.find(value);
if (it != std::end(config_item.labels)) return {STR_JUST_RAW_STRING, it->second};
return {STR_JUST_INT, value};
}
/**
* Get string to display this setting in the configuration interface.
* @param value Current value.
* @returns String to display.
*/
std::string ScriptConfigItem::GetString(int value) const
{
auto [param1, param2] = GetValueParams(*this, value);
return this->description.empty()
? ::GetString(STR_JUST_STRING1, param1, param2)
: ::GetString(STR_AI_SETTINGS_SETTING, this->description, param1, param2);
}
/**
* Get text colour to display this setting in the configuration interface.
* @returns Text colour to display this setting.
*/
TextColour ScriptConfigItem::GetColour() const
{
return this->description.empty() ? TC_ORANGE : TC_LIGHT_BLUE;
}