miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: Prefer string equality instead of comparison. (#14727)

Browse Source
This commit is contained in:
Peter Nelson
2025-10-24 20:30:03 +01:00
committed by dP
parent c9af1c1c7a
commit d284e02a87
15 changed files with 37 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/network_admin.cpp
View File

@@ -633,8 +633,7 @@ NetworkRecvStatus ServerNetworkAdminSocketHandler::Receive_ADMIN_JOIN(Packet &p)
std::string password = p.Recv_string(NETWORK_PASSWORD_LENGTH);
if (_settings_client.network.admin_password.empty() ||
_settings_client.network.admin_password.compare(password) != 0) {
if (_settings_client.network.admin_password.empty() || _settings_client.network.admin_password != password) {
/* Password is invalid */
return this->SendError(NETWORK_ERROR_WRONG_PASSWORD);
}