miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: use std::string_view for scripts

Browse Source
This commit is contained in:
Rubidium
2025-04-26 21:10:08 +02:00
committed by rubidium42
parent 864fe29028
commit b9667ec3d1
17 changed files with 77 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/script/script_scanner.cpp
View File

@@ -56,7 +56,7 @@ void ScriptScanner::ResetEngine()
this->RegisterAPI(this->engine);
}
void ScriptScanner::Initialize(const char *name)
void ScriptScanner::Initialize(std::string_view name)
{
this->engine = new Squirrel(name);
@@ -198,8 +198,8 @@ struct ScriptFileChecksumCreator : FileScanner {
static bool IsSameScript(const ContentInfo &ci, bool md5sum, ScriptInfo *info, Subdirectory dir)
{
uint32_t id = 0;
const char *str = info->GetShortName().c_str();
for (int j = 0; j < 4 && *str != '\0'; j++, str++) id |= *str << (8 * j);
auto str = std::string_view{info->GetShortName()}.substr(0, 4);
for (size_t j = 0; j < str.size(); j++) id |= static_cast<uint8_t>(str[j]) << (8 * j);
if (id != ci.unique_id) return false;
if (!md5sum) return true;