miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: Always pass raw strings to TextFilter's AddLine(). (#13666)

Browse Source 
Remove StringID overload, so callers have to preformat the string.
This commit is contained in:
Peter Nelson
2025-02-27 19:21:43 +00:00
committed by GitHub
parent b376e2655a
commit 8813a798e7
3 changed files with 4 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/settingentry_gui.cpp
View File

@@ -234,9 +234,8 @@ bool SettingEntry::UpdateFilterState(SettingFilter &filter, bool force_visible)
/* Process the search text filter for this item. */
filter.string.ResetState();
SetDParam(0, STR_EMPTY);
filter.string.AddLine(sd->GetTitle());
filter.string.AddLine(sd->GetHelp());
filter.string.AddLine(GetString(sd->GetTitle(), STR_EMPTY));
filter.string.AddLine(GetString(sd->GetHelp()));
visible = filter.string.GetState();
}
@@ -530,7 +529,7 @@ bool SettingsPage::UpdateFilterState(SettingFilter &filter, bool force_visible)
{
if (!force_visible && !filter.string.IsEmpty()) {
filter.string.ResetState();
filter.string.AddLine(this->title);
filter.string.AddLine(GetString(this->title));
force_visible = filter.string.GetState();
}