miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: remove const char* overloads when there are std::string_view and std::string& overloads

Browse Source
This commit is contained in:
Rubidium
2025-04-28 21:04:49 +02:00
committed by rubidium42
parent a5578166bb
commit 78250c3bba
13 changed files with 18 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/tests/string_func.cpp
View File

@@ -506,8 +506,8 @@ TEST_CASE("FixSCCEncodedNegative")
TEST_CASE("EncodedString::ReplaceParam - positive")
{
/* Test that two encoded strings with different parameters are not the same. */
EncodedString string1 = GetEncodedString(STR_NULL, "Foo", 10, "Bar");
EncodedString string2 = GetEncodedString(STR_NULL, "Foo", 15, "Bar");
EncodedString string1 = GetEncodedString(STR_NULL, "Foo"sv, 10, "Bar"sv);
EncodedString string2 = GetEncodedString(STR_NULL, "Foo"sv, 15, "Bar"sv);
CHECK(string1 != string2);
/* Test that replacing parameter results in the same string. */
@@ -517,9 +517,9 @@ TEST_CASE("EncodedString::ReplaceParam - positive")
TEST_CASE("EncodedString::ReplaceParam - negative")
{
EncodedString string1 = GetEncodedString(STR_NULL, "Foo", -1, "Bar");
EncodedString string2 = GetEncodedString(STR_NULL, "Foo", -2, "Bar");
EncodedString string3 = GetEncodedString(STR_NULL, "Foo", 0xFFFF'FFFF'FFFF'FFFF, "Bar");
EncodedString string1 = GetEncodedString(STR_NULL, "Foo"sv, -1, "Bar"sv);
EncodedString string2 = GetEncodedString(STR_NULL, "Foo"sv, -2, "Bar"sv);
EncodedString string3 = GetEncodedString(STR_NULL, "Foo"sv, 0xFFFF'FFFF'FFFF'FFFF, "Bar"sv);
/* Test that two encoded strings with different parameters are not the same. */
CHECK(string1 != string2);
/* Test that signed values are stored as unsigned. */