miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: use std::string_view for ini_key

Browse Source
This commit is contained in:
Rubidium
2025-05-01 17:07:46 +02:00
committed by rubidium42
parent d958d50985
commit 7805c1c189
33 changed files with 65 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/tests/test_window_desc.cpp
View File

@@ -32,11 +32,11 @@ private:
TEST_CASE("WindowDesc - ini_key uniqueness")
{
std::set<std::string> seen;
std::set<std::string_view> seen;
for (const WindowDesc *window_desc : *_window_descs) {
if (window_desc->ini_key == nullptr) continue;
if (window_desc->ini_key.empty()) continue;
CAPTURE(window_desc->ini_key);
CHECK((seen.find(window_desc->ini_key) == std::end(seen)));
@@ -49,7 +49,7 @@ TEST_CASE("WindowDesc - ini_key validity")
{
const WindowDesc *window_desc = GENERATE(from_range(std::begin(*_window_descs), std::end(*_window_descs)));
bool has_inikey = window_desc->ini_key != nullptr;
bool has_inikey = !window_desc->ini_key.empty();
bool has_widget = std::any_of(std::begin(window_desc->nwid_parts), std::end(window_desc->nwid_parts), [](const NWidgetPart &part) { return part.type == WWT_DEFSIZEBOX || part.type == WWT_STICKYBOX; });
INFO(fmt::format("{}:{}", window_desc->source_location.file_name(), window_desc->source_location.line()));