miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: use std::move when appropriate

Browse Source
This commit is contained in:
Rubidium
2025-03-08 20:33:08 +01:00
committed by rubidium42
parent 05ce0828c0
commit 754311a779
37 changed files with 83 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/network_client.cpp
+7 -7
View File
@@ -559,8 +559,8 @@ NetworkRecvStatus ClientNetworkGameSocketHandler::Receive_SERVER_CLIENT_INFO(Pac
if (client_id == _network_own_client_id) SetLocalCompany(!Company::IsValidID(playas) ? COMPANY_SPECTATOR : playas);
ci->client_playas = playas;
ci->client_name = name;
ci->public_key = public_key;
ci->client_name = std::move(name);
ci->public_key = std::move(public_key);
InvalidateWindowData(WC_CLIENT_LIST, 0);
@@ -579,8 +579,8 @@ NetworkRecvStatus ClientNetworkGameSocketHandler::Receive_SERVER_CLIENT_INFO(Pac
ci->client_playas = playas;
if (client_id == _network_own_client_id) this->SetInfo(ci);
ci->client_name = name;
ci->public_key = public_key;
ci->client_name = std::move(name);
ci->public_key = std::move(public_key);
InvalidateWindowData(WC_CLIENT_LIST, 0);
@@ -677,7 +677,7 @@ class ClientGamePasswordRequestHandler : public NetworkAuthenticationPasswordReq
if (!_network_join.server_password.empty()) {
request->Reply(_network_join.server_password);
} else {
ShowNetworkNeedPassword(request);
ShowNetworkNeedPassword(std::move(request));
}
}
};
@@ -936,7 +936,7 @@ NetworkRecvStatus ClientNetworkGameSocketHandler::Receive_SERVER_COMMAND(Packet
return NETWORK_RECV_STATUS_MALFORMED_PACKET;
}
this->incoming_queue.push_back(cp);
this->incoming_queue.push_back(std::move(cp));
return NETWORK_RECV_STATUS_OKAY;
}
@@ -1313,7 +1313,7 @@ void NetworkUpdateClientName(const std::string &client_name)
std::string temporary_name = client_name;
if (NetworkMakeClientNameUnique(temporary_name)) {
NetworkTextMessage(NETWORK_ACTION_NAME_CHANGE, CC_DEFAULT, false, ci->client_name, temporary_name);
ci->client_name = temporary_name;
ci->client_name = std::move(temporary_name);
NetworkUpdateClientInfo(CLIENT_ID_SERVER);
}
}