miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix 6e90b828c6: Off-by-one in Rect::CentreTo. (#14643)

Browse Source 
* Rect right/bottom are inclusive so -1 must be taken from width/height.
* Misnamed variable, `new_right` is actually `new_top`.
This commit is contained in:
Peter Nelson
2025-09-21 13:41:23 +01:00
committed by dP
parent 83bd4b6d0f
commit 48cf1cabbe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/geometry_type.hpp
View File

@@ -261,8 +261,8 @@ struct Rect {
[[nodiscard]] inline Rect CentreTo(int width, int height) const [[nodiscard]] inline Rect CentreTo(int width, int height) const
{ {
int new_left = CentreBounds(this->left, this->right, width); int new_left = CentreBounds(this->left, this->right, width);
int new_right = CentreBounds(this->top, this->bottom, height); int new_top = CentreBounds(this->top, this->bottom, height);
return {new_left, new_right, new_left + width, new_right + height}; return {new_left, new_top, new_left + width - 1, new_top + height - 1};
} }
}; };