miguel.horta/openttd-cmclient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codechange: remove char* from base driver code

Browse Source
This commit is contained in:
Rubidium
2025-04-29 16:27:13 +02:00
committed by rubidium42
parent d030d17bd6
commit 261e09a549
7 changed files with 47 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/music/extmidi.cpp
+6 -7
View File
@@ -43,22 +43,21 @@ std::optional<std::string_view> MusicDriver_ExtMidi::Start(const StringList &par
return "the extmidi driver does not work when Allegro is loaded.";
}
const char *command = GetDriverParam(parm, "cmd");
auto command = GetDriverParam(parm, "cmd");
#ifndef MIDI_ARG
if (StrEmpty(command)) command = EXTERNAL_PLAYER;
if (!command.has_value() || command->empty()) command = EXTERNAL_PLAYER;
#else
if (StrEmpty(command)) command = EXTERNAL_PLAYER " " MIDI_ARG;
if (!command.has_value() || command->empty()) command = EXTERNAL_PLAYER " " MIDI_ARG;
#endif
this->command_tokens.clear();
std::string_view view = command;
for (;;) {
auto pos = view.find(' ');
this->command_tokens.emplace_back(view.substr(0, pos));
auto pos = command->find(' ');
this->command_tokens.emplace_back(command->substr(0, pos));
if (pos == std::string_view::npos) break;
view.remove_prefix(pos + 1);
command->remove_prefix(pos + 1);
}
this->song.clear();