Files
openttd-android/src
Jonathan G Rennison 01f957c51f Fix: Crash due to use of invalid iterator in ClientNetworkContentSocketHandler
In particular this crash can be observed when using the
bootstrap GUI to download the base graphics.

In ClientNetworkContentSocketHandler::OnReceiveContentInfo
ClientNetworkContentSocketHandler::callbacks is iterated, using an iterator
cb->OnReceiveContentInfo() is called (cb is of type BootstrapAskForDownloadWindow)
This calls new BootstrapContentDownloadStatusWindow()
This inherits from BaseNetworkContentDownloadStatusWindow
The constructor of which calls _network_content_client.AddCallback(this)
This reallocates the std::vector which is being iterated in ClientNetworkContentSocketHandler::OnReceiveContentInfo
This results in iter being invalid, and an assertion failure occurs shortly
afterwards due to its use in the next iteration of cb->OnReceiveContentInfo()

Adjust all locations where ClientNetworkContentSocketHandler::callbacks
is iterated to avoid problematic behaviour
2019-04-09 22:56:23 +02:00
..
2019-04-09 22:45:15 +02:00
2019-04-09 19:45:42 +02:00
2019-03-16 22:30:11 +00:00
2019-04-09 22:45:15 +02:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-20 19:24:55 +01:00
2019-03-20 19:24:55 +01:00
2019-03-19 23:22:51 +01:00
2019-01-12 16:57:23 +00:00
2019-01-12 16:57:23 +00:00
2019-03-20 19:24:55 +01:00
2019-03-20 19:24:55 +01:00
2019-03-20 19:24:55 +01:00
2019-03-28 00:09:33 +01:00
2018-04-30 18:52:32 +02:00
2019-03-28 00:09:33 +01:00
2019-03-20 19:24:55 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2018-04-29 15:32:16 +02:00
2019-03-20 19:24:55 +01:00
2018-04-30 18:52:32 +02:00
2019-03-20 19:24:55 +01:00
2019-03-20 19:24:55 +01:00
2019-03-28 00:09:33 +01:00
2018-10-31 12:41:49 +01:00
2019-03-05 22:03:00 +01:00
2019-03-20 19:24:55 +01:00
2019-03-31 17:22:54 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-28 00:09:33 +01:00
2019-03-16 22:30:11 +00:00
2019-03-28 00:09:33 +01:00