miguel.horta/openttd-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add: use breakpad to create crash.dmp on MacOS / Linux too (#11202)

Browse Source 
Normally only the Windows platform could create a crash.dmp, making
analysing crash-reports from MacOS / Linux rather tricky.
This commit is contained in:
Patric Stout
2023-08-20 17:16:08 +02:00
committed by GitHub
parent 8f6df242c4
commit f120d2beb8
13 changed files with 107 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/crashlog.cpp
View File

@@ -369,9 +369,14 @@ bool CrashLog::WriteCrashLog()
return len == written;
}
/**
* Write the (crash) dump to a file.
*
* @note Sets \c crashdump_filename when there is a successful return.
* @return 1 iff the crashdump was successfully created, -1 if it failed, 0 if not implemented.
*/
/* virtual */ int CrashLog::WriteCrashDump()
{
/* Stub implementation; not all OSes support this. */
return 0;
}
@@ -452,13 +457,15 @@ bool CrashLog::MakeCrashLog()
ret = false;
}
/* Don't mention writing crash dumps because not all platforms support it. */
fmt::print("Writing crash dump to disk...\n");
int dret = this->WriteCrashDump();
if (dret < 0) {
fmt::print("Writing crash dump failed.\n\n");
ret = false;
} else if (dret > 0) {
fmt::print("Crash dump written to {}. Please add this file to any bug reports.\n\n", this->crashdump_filename);
} else {
fmt::print("Skipped; missing dependency to create crash dump.\n");
}
fmt::print("Writing crash savegame...\n");